[webkit-reviews] review denied: [Bug 14251] onchange handler for
select controls doesn't fire when changing via keyboard :
[Attachment 15151] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 21 23:49:46 PDT 2007
Darin Adler <darin at apple.com> has denied Matt Perry <mpComplete at gmail.com>'s
request for review:
Bug 14251: onchange handler for select controls doesn't fire when changing via
keyboard
http://bugs.webkit.org/show_bug.cgi?id=14251
Attachment 15151: patch
http://bugs.webkit.org/attachment.cgi?id=15151&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Needs a layout test. We require tests for bug fixes like this one so they don't
regress in the future.
Fix itself looks pretty good, although the (size_t) casts don't see to be part
of the fix (and so should be done separately).
More information about the webkit-reviews
mailing list