[webkit-reviews] review denied: [Bug 14269] REGRESSION: Gmail links stop working after computer sleep : [Attachment 15154] WebCore/Timer.cpp patch to work around the problem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 21 07:40:30 PDT 2007


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied 's request for review:
Bug 14269: REGRESSION: Gmail links stop working after computer sleep
http://bugs.webkit.org/show_bug.cgi?id=14269

Attachment 15154: WebCore/Timer.cpp patch to work around the problem
http://bugs.webkit.org/attachment.cgi?id=15154&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Thanks for the patch and the detective work, Ruben!

NOTE: I'm not reviewing the correctness of the code changes in the patch, but
instead the patch itself.

1. Please create a ChangeLog entry for this patch using
WebKitTools/Scripts/prepare-ChangeLog.

2. Please use WebKitTools/Scripts/svn-create-patch to generate a patch of the
ChangeLog entry and the code fix.

3. All changes need a layout test unless it's not possible to make one.  (In
this case, I'd say it's not possible to emulate sleeping for over 5 minutes in
the layout tests, so just note this in the ChangeLog entry as well.)

More details here:  http://webkit.org/coding/contributing.html

Please make the above corrections and attach a new patch.  Please also set the
"review?" flag on the patch so that reviewers will notice it.  Thanks again!



More information about the webkit-reviews mailing list