[webkit-reviews] review denied: [Bug 13981] <br> prevents click handler from firing : [Attachment 15084] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 18 10:08:50 PDT 2007

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 13981: <br> prevents click handler from firing

Attachment 15084: First attempt

------- Additional Comments from Eric Seidel <eric at webkit.org>
This line needs to be made more understandable:
-	 if (child->nodeAtPoint(request, result, _x, _y, _tx, _ty,
hitTestAction)) {
+	 if (child->nodeAtPoint(request, result, _x - (_tx - ctm.e()), _y -
(_ty - ctm.f()), 0, 0, hitTestAction)) {

by breaking it out into more lines with better names.

The code otherwise looks fine.

More information about the webkit-reviews mailing list