[webkit-reviews] review denied: [Bug 14154] Spinneret doesn't build against the new Win32 port. : [Attachment 15056] A fix of the fix (includes changelog)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 17 21:18:33 PDT 2007


Adam Roben <aroben at apple.com> has denied Jake <jake at jakeonthenet.com>'s request
for review:
Bug 14154: Spinneret doesn't build against the new Win32 port.
http://bugs.webkit.org/show_bug.cgi?id=14154

Attachment 15056: A fix of the fix (includes changelog)
http://bugs.webkit.org/attachment.cgi?id=15056&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
-    $safariPath = "cmd";
+    $safariPath = "echo";

   This change looks wrong -- won't it break run-safari?

+    hr = viewExt->viewWindow(((OLE_HANDLE*) &gViewWindow));

   You've got an extra set of parentheses here.



More information about the webkit-reviews mailing list