[webkit-reviews] review denied: [Bug 13884] patch for prepare-ChangeLog to populate ChangeLog files from a git commit : [Attachment 14848] third version of prepare-ChangeLog patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Simon Hausmann
<hausmann at kde.org>'s request for review:
Bug 13884: patch for prepare-ChangeLog to populate ChangeLog files from a git
commit
http://bugs.webkit.org/show_bug.cgi?id=13884

Attachment 14848: third version of prepare-ChangeLog patch
http://bugs.webkit.org/attachment.cgi?id=14848&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
These two changes seem wrong. Why are you changing the line that has isSVN()
and testing for $gitCommit there? Shouldn't that be on the line with isGit()?

@@ -999,7 +1074,7 @@ sub isModifiedOrAddedStatus($)
	 "renamed" => 1,
     );
 
-    return $svn{$status} if isSVN();
+    return $svn{$status} if (isSVN() || $gitCommit);
     return $git{$status} if isGit();
 }
 
@@ -1037,7 +1112,7 @@ sub statusDescription($$)
	 "renamed" => " Renamed from \%s.",
     );
 
-    return sprintf($svn{$status}, $original) if isSVN() && exists
$svn{$status};
+    return sprintf($svn{$status}, $original) if (isSVN() || $gitCommit) &&
exists $svn{$status};
     return sprintf($git{$status}, $original) if isGit() && exists
$git{$status};
     return undef;
 }