[webkit-reviews] review denied: [Bug 14111] Autogenerate Event JS binding : [Attachment 14991] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 20:53:09 PDT 2007

Darin Adler <darin at apple.com> has denied Sam Weinig <sam at webkit.org>'s request
for review:
Bug 14111: Autogenerate Event JS binding

Attachment 14991: patch

------- Additional Comments from Darin Adler <darin at apple.com>
Is there no way to avoid special-casing clipboardData and dataTransfer? Can't
we just move those to the appropriate event classes?

+    // FIXME: Is this lock necessary?
+    KJS::JSLock lock;

Seems clear that it is.

+	     if (WebCore::JSUnprotectedEventListener* listener =
Why is the WebCore prefix needed?

-	 [OldStyleObjC] void initEvent(in DOMString eventTypeArg, 
+	 [OldStyleObjC] void initEvent(in AtomicString eventTypeArg, 

This seems wrong. The API should be DOMString even though the implementation is

More information about the webkit-reviews mailing list