[webkit-reviews] review denied: [Bug 13038] ASSERTION FAILED:
item->target().isEmpty() ||
m_mainFrame->tree()->find(item->target()) == m_mainFrame :
[Attachment 15016] proposed patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 14 18:08:25 PDT 2007
Brady Eidson <beidson at apple.com> has denied Maxime BRITTO <mbritto at pleyo.com>'s
request for review:
Bug 13038: ASSERTION FAILED: item->target().isEmpty() ||
m_mainFrame->tree()->find(item->target()) == m_mainFrame
http://bugs.webkit.org/show_bug.cgi?id=13038
Attachment 15016: proposed patch 2
http://bugs.webkit.org/attachment.cgi?id=15016&action=edit
------- Additional Comments from Brady Eidson <beidson at apple.com>
Please fill in your name and email address at the head of your change log (more
info on the env. variables that would do it can be found at webkit.org)
Please describe the change in the changelog
The .xcodeproj change is not necessary
And finally, this *will* need a layout test.
Good exploration and code change though! I'll r+ it once those things have
been addressed
More information about the webkit-reviews
mailing list