[webkit-reviews] review denied: [Bug 14086] Safari 3 beta has
severe rendering issues on non-English installs of Windows :
[Attachment 15031] Fix the memory leaks of CFStrings,
add code to guard against malformed/malicious font data.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 14 14:30:59 PDT 2007
Mark Rowe (bdash) <bdash at webkit.org> has denied Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 14086: Safari 3 beta has severe rendering issues on non-English installs of
Windows
http://bugs.webkit.org/show_bug.cgi?id=14086
Attachment 15031: Fix the memory leaks of CFStrings, add code to guard against
malformed/malicious font data.
http://bugs.webkit.org/attachment.cgi?id=15031&action=edit
------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
+ if (bufferSize < 6)
+ return NULL;
+ if (bufferSize < stringsOffset)
+ return NULL;
These early returns, and others further on in the function, leak the contents
of "buffer".
More information about the webkit-reviews
mailing list