[webkit-reviews] review granted: [Bug 12207] RenderSVGContainer should be split into multiple classes : [Attachment 14988] Split out RenderSVGRoot

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 12207: RenderSVGContainer should be split into multiple classes
http://bugs.webkit.org/show_bug.cgi?id=12207

Attachment 14988: Split out RenderSVGRoot
http://bugs.webkit.org/attachment.cgi?id=14988&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Eventually we'll need a better solution to this:

+	 // FIXME: All this setup should be done after attributesChanged, not
here.
+	 rootContainer->setViewBox(viewBox());
+	
rootContainer->setAlign(SVGPreserveAspectRatio::SVGPreserveAspectRatioType(pres
erveAspectRatio()->align()));
+	 rootContainer->setSlice(preserveAspectRatio()->meetOrSlice() ==
SVGPreserveAspectRatio::SVG_MEETORSLICE_SLICE);

We'll need to find a way to abstract a bunch of this code so it's not so
copy/paste.

It looks fine for a start.  We'll need follow up patches to clean up these
newly split classes.