[webkit-reviews] review denied: [Bug 13038] ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame : [Attachment 14930] Patch proposition to avoid the assertion error

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 13:57:06 PDT 2007


Mark Rowe (bdash) <bdash at webkit.org> has denied Maxime BRITTO
<mbritto at pleyo.com>'s request for review:
Bug 13038: ASSERTION FAILED: item->target().isEmpty() ||
m_mainFrame->tree()->find(item->target()) == m_mainFrame
http://bugs.webkit.org/show_bug.cgi?id=13038

Attachment 14930: Patch proposition to avoid the assertion error
http://bugs.webkit.org/attachment.cgi?id=14930&action=edit

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
To make changes easier to follow, we prefer to separate style changes from
behavioural changes.  If you could prepare a patch that only includes your
behavioural change it would be much easier to review + land.



More information about the webkit-reviews mailing list