[webkit-reviews] review requested: [Bug 13933] REGRESSION: fast/history/clicked-link-is-visited is failing : [Attachment 14926] Fix Adele's test to reload through DRT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 10 15:06:52 PDT 2007

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 13933: REGRESSION: fast/history/clicked-link-is-visited is failing

Attachment 14926: Fix Adele's test to reload through DRT

------- Additional Comments from Beth Dakin <bdakin at apple.com>
I have a fix! Having the test reload through DRT's queueReload mechanism fixes
the problem. I confirmed that this is still a valid test for the bug it
originally fixed by rolling Adele's patch out of my tree. And sure enough, with
Adele's patch gone, this new test also crashes. (Meaning it's valid!) My
totally-pulled-out-of-my-ass threory is that reloading through JS got DRT's
history all messed up. Maybe off-by-one? So DRT did not color the link the
visited color because it did not make it into the history list yet. Or

More information about the webkit-reviews mailing list