[webkit-reviews] review requested: [Bug 14030] Add a setClient method to ResourceHandle : [Attachment 14903] Add setClient to ResourceHandle, use it, check for NULL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 14:32:17 PDT 2007


Marvin Decker <marv.decker at gmail.com> has asked  for review:
Bug 14030: Add a setClient method to ResourceHandle
http://bugs.webkit.org/show_bug.cgi?id=14030

Attachment 14903: Add setClient to ResourceHandle, use it, check for NULL
http://bugs.webkit.org/attachment.cgi?id=14903&action=edit

------- Additional Comments from Marvin Decker <marv.decker at gmail.com>
This simple patch just adds and implements setClient on ResourceHandle. I added
setClient(NULL) in ResourceLoader before the handle is released, which is the
important part (so the handle doesn't try to call back on the unowned pointer
if it lives beyond this release).

I also added NULL checks before the client is accessed. I ended up changing the
Mac (many cases) and CFNet (sometimes it was already checking, so I only needed
a few) ports. The Qt port seems to reliable check for NULL already. I am happy
to make a new patch without any of these port changes if you would prefer, I
just wanted to try to reduce mysterious crashes down the like for the different
embedders).



More information about the webkit-reviews mailing list