[webkit-reviews] review denied: [Bug 12122] SVGPathElement should not inherit from SVGPathParser : [Attachment 14845] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 5 15:40:05 PDT 2007

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 12122: SVGPathElement should not inherit from SVGPathParser

Attachment 14845: First attempt

------- Additional Comments from Eric Seidel <eric at webkit.org>
It's a rather incomplete fix.  Basically you're just adding another class to
codify the existing hack of needing to allocate a class to do the parsing.  If
you're going to add this PathBuilder class, i would think you would make
SVGPathElement use it too.  I don't think that this fix is really much better
than the existing hack.  If you got rid of the other instances of classes
inheriting from SVGPathParser, that would be a more complete fix.  We can chat
about this on IRC if you like.

More information about the webkit-reviews mailing list