[webkit-reviews] review denied: [Bug 13985]
WebCore/rendering/RenderTable.cpp fails to compile with gcc
4.2.x : [Attachment 14851] Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 4 09:48:34 PDT 2007
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied 's request for review:
Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x
http://bugs.webkit.org/show_bug.cgi?id=13985
Attachment 14851: Fix
http://bugs.webkit.org/attachment.cgi?id=14851&action=edit
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Thanks for posting a patch to fix this, Bernhard!
In the future, please set the "review?" flag on patches so that they may be
flagged for review, and please add a ChangeLog entry for the updates. See this
page for more details: http://webkit.org/coding/contributing.html
>- borderWidth = max(borderWidth, gb.width);
>+ borderWidth = max(borderWidth, (unsigned int)gb.width);
In all of these cases, we prefer to use the static_cast<>() syntax and
"unsigned" instead of "unsigned int":
>+ borderWidth = max(borderWidth,
static_cast<unsigned>(gb.width));
Please add a ChangeLog entry, update the patch and repost. Thanks!
More information about the webkit-reviews
mailing list