[webkit-reviews] review denied: [Bug 14757] REGRESSION: HTMLTokenizer::processingData implementation is incorrect : [Attachment 15709] patch with assertion fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 12:43:52 PDT 2007

Brady Eidson <beidson at apple.com> has denied Matt Perry <mpComplete at gmail.com>'s
request for review:
Bug 14757: REGRESSION: HTMLTokenizer::processingData implementation is

Attachment 15709: patch with assertion fix

------- Additional Comments from Brady Eidson <beidson at apple.com>
I think this fix is pretty darned good.  
r- for one issue.
You replace the stopForUserCancel() call with a stopAllLoaders() and
scheduleCheckLoadComplete() call.
It is not obvious to me that those two lines replace the behavior of
"stopForUserCancell()" but just do it asynchronously.
I think it'd be better for future maintainability if stopForUserCancel() had an
asynchronous flag added, and that method decides whether to do the load
complete check now, or later.

More information about the webkit-reviews mailing list