[webkit-reviews] review requested: [Bug 14729] [gtk] Implement FrameLoaderClientGdk::createFrame : [Attachment 15755] Implement ScrollView similiar to win/qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 07:19:28 PDT 2007

Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 14729: [gtk] Implement FrameLoaderClientGdk::createFrame

Attachment 15755: Implement ScrollView similiar to win/qt

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Compared to the previous patch:

-Make it compile on case-sensitive filesystems (PlatformScrollbar.h vs.
-Add (again) refcounting to PlatformScrollbar and ScrollView
-Implement forall and unrealize in WebKitGtkPage to make issues on exit go
-Fixup some comments.

The biggest part of the patch is copy and paste from the windows port. The
controversal change is in Widget to use one of the two possible IntRect
conversion methods. I think this change is fine, other approaches would be to
move this code to PlatformScrollbar or to subclass PlatformScrollbar and use
that subclss in ScrollView.

I think this is commit-worthy.

More information about the webkit-reviews mailing list