[webkit-reviews] review requested: [Bug 14729] [gtk] Implement FrameLoaderClientGdk::createFrame : [Attachment 15748] Implement ScrollView similiar to win/qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 30 12:42:19 PDT 2007


Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 14729: [gtk] Implement FrameLoaderClientGdk::createFrame
http://bugs.webkit.org/show_bug.cgi?id=14729

Attachment 15748: Implement ScrollView similiar to win/qt
http://bugs.webkit.org/attachment.cgi?id=15748&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
It has the same controversal change as the previous attachment. This patch
changes the following things:

  -It should apply against ToT
  -It handles getting embedded into a GtkScrolledWindow nicely by using
GtkAdjustment

Known issues:
  -On destructing it seems I get ref counting of the PlatformScrollbar wrong.
  -We might create and destroy PlatformScrollbar too often (same as on Windows
and not introduced by this patch)



More information about the webkit-reviews mailing list