[webkit-reviews] review requested: [Bug 14797] [gtk] Make
GraphicsContext use a full GdkEventExpose* to ease
implementing Widget::paint : [Attachment 15715] Store
GdkEventExpose* in GraphicsContext and implement Widget::paint
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 27 20:11:32 PDT 2007
Holger Freyther <freyther at handhelds.org> has asked for review:
Bug 14797: [gtk] Make GraphicsContext use a full GdkEventExpose* to ease
implementing Widget::paint
http://bugs.webkit.org/show_bug.cgi?id=14797
Attachment 15715: Store GdkEventExpose* in GraphicsContext and implement
Widget::paint
http://bugs.webkit.org/attachment.cgi?id=15715&action=edit
------- Additional Comments from Holger Freyther <freyther at handhelds.org>
-No ChangeLog entry as it requires 14781
-This is a patch from git and won't apply with svn-apply
-setGdkExposeEvent matches the Qt naming of such methods (e.g.
mousePressEvent,...) but the parameter has it reversed with GdkEventExpose. I
think the way I named the method follows the WebCore naming style and is the
way to go.
-I ignore the clip rect of Widget::paint but that should directly come from the
expose event anyway.
More information about the webkit-reviews
mailing list