[webkit-reviews] review requested: [Bug 14757] REGRESSION: HTMLTokenizer::processingData implementation is incorrect : [Attachment 15709] patch with assertion fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 27 14:10:00 PDT 2007


Matt Perry <mpComplete at gmail.com> has asked  for review:
Bug 14757: REGRESSION: HTMLTokenizer::processingData implementation is
incorrect
http://bugs.webkit.org/show_bug.cgi?id=14757

Attachment 15709: patch with assertion fix
http://bugs.webkit.org/attachment.cgi?id=15709&action=edit

------- Additional Comments from Matt Perry <mpComplete at gmail.com>
This is like my previous patch, except:
- FrameLoader::stopForUserCancel does what it always did.
- DOMWindow::stop (window.stop) no longer calls stopForUserCancel.  It cancels
the load and then schedules a load-complete check asynchronously.

This fixes the original bug while still passing all tests and not hitting the
assertion I had in comment #8.



More information about the webkit-reviews mailing list