[webkit-reviews] review denied: [Bug 14745] WebKitTools/Scripts/run-launcher doesn't speak --gdk : [Attachment 15690] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 09:40:34 PDT 2007

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Nigel Tao
<nigel.tao.gnome at gmail.com>'s request for review:
Bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk

Attachment 15690: Patch

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Looks great!  I'm going to give it an r- since I'd like to see a ChangeLog
entry, and I have one minor quibble below.

>+  # Strip --gdk from the arg-list, since otherwise GdkLauncher will try to
>+  # interpret it as a URL.
>+  @args = grep(!/^(--gdk)$/, @ARGV);

Please use @args instead of @ARGV here.  If someone changes the script later to
process @args differently above, then this code won't pick up those changes. 

More information about the webkit-reviews mailing list