[webkit-reviews] review denied: [Bug 14745] WebKitTools/Scripts/run-launcher doesn't speak --gdk : [Attachment 15690] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Nigel Tao
<nigel.tao.gnome at gmail.com>'s request for review:
Bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
http://bugs.webkit.org/show_bug.cgi?id=14745

Attachment 15690: Patch
http://bugs.webkit.org/attachment.cgi?id=15690&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Looks great!  I'm going to give it an r- since I'd like to see a ChangeLog
entry, and I have one minor quibble below.

>+  # Strip --gdk from the arg-list, since otherwise GdkLauncher will try to
>+  # interpret it as a URL.
>+  @args = grep(!/^(--gdk)$/, @ARGV);

Please use @args instead of @ARGV here.  If someone changes the script later to
process @args differently above, then this code won't pick up those changes. 
Thanks!