[webkit-reviews] review denied: [Bug 14757] HTMLTokenizer::processingData implementation is incorrect : [Attachment 15688] above patch with test hang fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 25 20:05:10 PDT 2007

Darin Adler <darin at apple.com> has denied Matt Perry <mpComplete at gmail.com>'s
request for review:
Bug 14757: HTMLTokenizer::processingData implementation is incorrect

Attachment 15688: above patch with test hang fix

------- Additional Comments from Darin Adler <darin at apple.com>
(In reply to comment #3)
> However, it seems to me that a new test is unnecessary, since
> should obviously return true if HTMLTokenizer is still inside the write()
> function.

Sorry, I think there's a misunderstanding here.

A new test is necessary. Proving that the fix is correct is only one reason to
add a test. The more important reason for a test is to prevent the bug from
being reintroduced later on.

We definitely need to add a test for this unless it's impractical. The patch
should include that test.

+    //return m_timer.isActive();

We don't check in commented-out code.

More information about the webkit-reviews mailing list