[webkit-reviews] review granted: [Bug 14030] Add a setClient method
to ResourceHandle : [Attachment 15670] New patch that applies
cleanly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 24 14:15:05 PDT 2007
Darin Adler <darin at apple.com> has granted Marvin Decker
<marv.decker at gmail.com>'s request for review:
Bug 14030: Add a setClient method to ResourceHandle
http://bugs.webkit.org/show_bug.cgi?id=14030
Attachment 15670: New patch that applies cleanly
http://bugs.webkit.org/attachment.cgi?id=15670&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ if (m_handle.get())
Don't need a .get() on the line above.
+ m_handle->setClient(NULL);
We normally use 0 for such things, not NULL.
+ // The client may be NULL, in which case no callbacks will be made.
We don't call this "NULL".
r=me since Maciej reviewed this previously and it looks fine.
More information about the webkit-reviews
mailing list