[webkit-reviews] review granted: [Bug 14711] RenderThemeGdk's buttons are state-agnostic (pressed, hovered) : [Attachment 15666] Make use of widget state in RenderThemeGdk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 11:29:00 PDT 2007


Adam Roben <aroben at apple.com> has granted Alp Toker <alp at atoker.com>'s request
for review:
Bug 14711: RenderThemeGdk's buttons are state-agnostic (pressed, hovered)
http://bugs.webkit.org/show_bug.cgi?id=14711

Attachment 15666: Make use of widget state in RenderThemeGdk
http://bugs.webkit.org/attachment.cgi?id=15666&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
isChecked(o) ? GTK_SHADOW_IN : GTK_SHADOW_OUT

Perhaps this code should become another helper function called `checkedState`
(or shadowState if that makes more sense in Gtk terminology)

r=me



More information about the webkit-reviews mailing list