[webkit-reviews] review denied: [Bug 14745]
WebKitTools/Scripts/run-launcher doesn't speak --gdk :
[Attachment 15660] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 24 07:45:24 PDT 2007
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied 's request for review:
Bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
http://bugs.webkit.org/show_bug.cgi?id=14745
Attachment 15660: Patch
http://bugs.webkit.org/attachment.cgi?id=15660&action=edit
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Thanks for the patch, Nigel! In the future, please set the "review?" flag on
patches to make sure they're reviewed in a timely manner.
>- $launcherPath = "$launcherPath/WebKitTools/GdkLauncher";
>+ $launcherPath = "$launcherPath/WebKitTools/GdkLauncher/GdkLauncher";
This looks correct.
>+ else if (currArg[0] == '-') // currArg looks like an (unknown)
-flag, not a URL
>+ ; // No-op. We'll just silently ignore unknown flags
This looks like a different bug? Why is this change needed?
However, this patch is missing a ChangeLog entry. See this page for details on
how to create one using the prepare-ChangeLog script:
http://webkit.org/coding/contributing.html
Setting review- flag for no ChangeLog and unknown change to main.cpp. Please
make these fixes and repost the patch. Thanks!
More information about the webkit-reviews
mailing list