[webkit-reviews] review requested: [Bug 14383] [S60] Problem with
CPluginSkin::PluginScriptableObject : [Attachment 15648] 3.1
patch - Updated as per review comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 23 06:27:50 PDT 2007
maheshK <mahesh.kulkarni at nokia.com> has asked Sachin Padma
<Sachin.Padma at nokia.com> for review:
Bug 14383: [S60] Problem with CPluginSkin::PluginScriptableObject
http://bugs.webkit.org/show_bug.cgi?id=14383
Attachment 15648: 3.1 patch - Updated as per review comments
http://bugs.webkit.org/attachment.cgi?id=15648&action=edit
------- Additional Comments from maheshK <mahesh.kulkarni at nokia.com>
Changes made as per comments,
1) Made function return value. Leave happens only on special cases as per
comments from sachin.
2) uidPtr can not be removed, as repository->Get takes reference pointer and by
trying to pass Des() of uid giving compilation error.
More information about the webkit-reviews
mailing list