[webkit-reviews] review requested: [Bug 6129] Incomplete implementation of CSS 2.1 system colors : [Attachment 15614] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 21 12:55:46 PDT 2007

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 6129: Incomplete implementation of CSS 2.1 system colors

Attachment 15614: First attempt

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This patch uses the same code basically as Mozilla codebase, old carbon calls.
Not surprisingly that it matches FF2 with this test:


There are some things to clear up:

- is it ok to use the old Carbon calls? I guess NSColor could workI guess but
it needs more lines.
- already since the patch changes ButtonFace value on my system so a lot of
regressions are there in the  non-pixel tests, so a lot of tests would need to
be updated.
- would we get system color dependent test results after this patch? How to do
an added testcase if it would depend on the system the test runs on? I am not
sure how much the system colors can be changed by the average user, but at
least highlight color can be changed.


More information about the webkit-reviews mailing list