[webkit-reviews] review denied: [Bug 14661] [s60] Some input format doesn't work properly : [Attachment 15563] added style format functionality to text edit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 13:47:12 PDT 2007


Zalan Bujtas <zbujtas at gmail.com> has denied Rasvan Alexandrescu
<rasvan.alexandrescu at nokia.com>'s request for review:
Bug 14661: [s60] Some input format doesn't work properly
http://bugs.webkit.org/show_bug.cgi?id=14661

Attachment 15563: added style format functionality to text edit 
http://bugs.webkit.org/attachment.cgi?id=15563&action=edit

------- Additional Comments from Zalan Bujtas <zbujtas at gmail.com>
the patch looks good. there is a tiny coding conventional issue in the
following line
+    TBool aIsEmptyOk (!aInputRequired);

and actually, i'm not sure if this line is needed at all.



More information about the webkit-reviews mailing list