[webkit-reviews] review denied: [Bug 14383] [S60] Problem with CPluginSkin::PluginScriptableObject : [Attachment 15482] 3.1m Patch for scriptability check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 09:02:10 PDT 2007


Sachin Padma <Sachin.Padma at nokia.com> has denied maheshK
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 14383: [S60] Problem with CPluginSkin::PluginScriptableObject
http://bugs.webkit.org/show_bug.cgi?id=14383

Attachment 15482: 3.1m Patch for scriptability check
http://bugs.webkit.org/attachment.cgi?id=15482&action=edit

------- Additional Comments from Sachin Padma <Sachin.Padma at nokia.com>
You cannot use leave to return a value from function. Please leave only if
there is a critical error like memory allocation failure etc. Otherwise return
a value. No need for uidPtr, just pass in Des()



More information about the webkit-reviews mailing list