[webkit-reviews] review granted: [Bug 14569] Repro crash due to saved state not being cleared when select and textarea elements are adopted by another document : [Attachment 15540] unregister/register when moving between documents with class to factor out state logic

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 14569: Repro crash due to saved state not being cleared when select and
textarea elements are adopted by another document
http://bugs.webkit.org/show_bug.cgi?id=14569

Attachment 15540: unregister/register when moving between documents with class
to factor out state logic
http://bugs.webkit.org/attachment.cgi?id=15540&action=edit

------- Additional Comments from mitz at webkit.org
Cool! This is the "third option" that I told Brady is was considering.

+	 (WebCore::HTMLSelectElement::~HTMLSelectElement): Removed the call to
+	 unregisterFormElementWithState.

 HTMLSelectElement::~HTMLSelectElement()
 {
-    document()->unregisterFormElementWithState(this);
 }
 
I don't understand why you left the empty destructor in this case but not in
the text area case.

r=me!