[webkit-reviews] review denied: [Bug 14631] <use> doesn't deep-expand <symbol> elements. : [Attachment 15530] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 16 11:53:51 PDT 2007

Rob Buis <rwlbuis at gmail.com> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 14631: <use> doesn't deep-expand <symbol> elements.

Attachment 15530: Initial patch

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
>--- WebCore/ChangeLog	(revision 24303)
>+++ WebCore/ChangeLog	(working copy)
>+	  Added testcase:
svg/custom/use-on-g-containing-foreignObject-and-image.svg (testcase for
>+			  svg/custom/use-on-disallowed-foreign-object-5.svg
(<use> on <symbol> containg <foreignObject>)
>+			  svg/custom/use-on-disallowed-foreign-object-6.svg
(<use> on <g> containing <svg> containing <foreignObject>)
>+			  svg/custom/use-on-disallowed-foreign-object-7.svg
(<use> on <g> containing <symbol> containing <foreignObject>)

I wouldn't add the testcases here, but that is a taste thing I suppose.

>Index: LayoutTests/svg/custom/use-on-g-containing-foreignObject-and-image.svg
>--- LayoutTests/svg/custom/use-on-g-containing-foreignObject-and-image.svg    
(revision 0)
>+++ LayoutTests/svg/custom/use-on-g-containing-foreignObject-and-image.svg    
(revision 0)
>@@ -0,0 +1,14 @@
>+<?xml version="1.0"?>
>+<svg xmlns="http://www.w3.org/2000/svg"
>+     xmlns:xlink="http://www.w3.org/1999/xlink">
>+    <g id="container">
>+	  <foreignObject x="10" y="10" width="580" height="380"
>+	  <image xlink:href="resources/green-checker.png" width="75"
height="75" />
>+    </g>
>+<use x="25" y="25" xlink:href="#container"/>

I do not understand why you don't add a testcase like this but using <switch>
instead of <g>. AFAICS switch has some unique effect, in that it can
render the foreignObject in <use> valid, since the <switch> can decide to rule
out the foreignObject, which the above <g> doesn't do.
If we can work that one out (over irc maybe), then I'll r+ it.

More information about the webkit-reviews mailing list