[webkit-reviews] review requested: [Bug 9697] parseInt results may be inaccurate for numbers greater than 2^53 : [Attachment 15528] Revised proposed patch

[bugzilla-daemon at webkit.org]

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 9697: parseInt results may be inaccurate for numbers greater than 2^53
http://bugs.webkit.org/show_bug.cgi?id=9697

Attachment 15528: Revised proposed patch
http://bugs.webkit.org/attachment.cgi?id=15528&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Thanks for your prompt comments. I (hopefully!) fixed the style issues. I bit
the ASCII bug and moved everything into one function, and I made a named
constant for the overflow check. Adam pointed out one problem, which I realized
after I submitted the patch, and there was another small problem of not
checking for the decimal point in addition to the exponent symbol before
calling strtod(). I also removed the usage of the GCC extension and the
pointless copying of the string.