[webkit-reviews] review granted: [Bug 14020] [GDK] Jumbled text during initial load of a large page : [Attachment 15523] Update the scrollbars once when ScrollView::update gets called

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 15 23:51:01 PDT 2007


Maciej Stachowiak <mjs at apple.com> has granted Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 14020: [GDK] Jumbled text during initial load of a large page
http://bugs.webkit.org/show_bug.cgi?id=14020

Attachment 15523: Update the scrollbars once when ScrollView::update gets
called
http://bugs.webkit.org/attachment.cgi?id=15523&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Tiny nitpicks:

"lead to less often layouting" - there's no such word as layouting in English,
layout is only a noun, not a verb. "lead to laying out less often" would be the
way to say it.


+    if (m_data->scrollBarsNeedUpdate) {
+	 updateScrollbars();
+    }

Shouldn't be braces here.

You can fix these before committing, otherwise r=me.



More information about the webkit-reviews mailing list