[webkit-reviews] review granted: [Bug 14609] gdk painting changes :
[Attachment 15502] Painting Chnages
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 15 15:50:19 PDT 2007
Nikolas Zimmermann <zimmermann at kde.org> has granted Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 14609: gdk painting changes
http://bugs.webkit.org/show_bug.cgi?id=14609
Attachment 15502: Painting Chnages
http://bugs.webkit.org/attachment.cgi?id=15502&action=edit
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hi Holger,
even though I'm not a gdk/gtk expert this looks like a nice patch.
I'm not sure wheter you are adhering to the style guide in the gdk port, if
yes, tiny remark:
+struct FrameGdkExposeData{
+ GtkContainer *container;
+ GdkEventExpose *expose;
+};
missing space after {, stars should be moved.
+
+static void
+frame_gdk_expose_child(GtkWidget *widget, gpointer _data)
+{
Don't use two lines here.
Other than style remarks, all fine, r=me.
Greetings,
Niko
More information about the webkit-reviews
mailing list