[webkit-reviews] review granted: [Bug 14145] RenderSVGContainer
should not inherit from RenderContainer : [Attachment 15522]
Initial patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 14 15:47:54 PDT 2007
Oliver Hunt <oliver at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 14145: RenderSVGContainer should not inherit from RenderContainer
http://bugs.webkit.org/show_bug.cgi?id=14145
Attachment 15522: Initial patch
http://bugs.webkit.org/attachment.cgi?id=15522&action=edit
------- Additional Comments from Oliver Hunt <oliver at apple.com>
// Only the root <svg> element should need any translations using the
HTML/CSS system
// parentX, parentY are also non-zero for first-level kids of these
// CSS-transformed <svg> root-elements (due to RenderBox::paint) for any
other element
// they should be 0. m_x, m_y should always be 0 for non-root svg
containers
- ASSERT(m_x == 0);
- ASSERT(m_y == 0);
should the assertions not become isRoot || m_x == 0
etc?
More information about the webkit-reviews
mailing list