[webkit-reviews] review cancelled: [Bug 13517] DOM Exception 8 in finance.aol.com sub-page : [Attachment 15495] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 03:56:59 PDT 2007

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has cancelled Cameron Zwarich
(cpst) <cwzwarich at uwaterloo.ca>'s request for review:
Bug 13517: DOM Exception 8 in finance.aol.com sub-page

Attachment 15495: Proposed patch

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here is a revised version of my patch. It fixes one coding style issue, and a
regression on the test fast/js/const (the build was broken, so I submitted it
only using the old JS tests).

I added test cases for these two bugs. Alexey asked me why I copied the
arguments check that was introduced in the patch for bug 13456 in addition to
the first check, so I added test cases to fast/js/vardecl-preserve-arguments
that would fail if that second check weren't there.

When fast/js/const failed, I fixed it by adding code to apply the ReadOnly
attribute. In the process of doing so, I found a few existing bugs in the
handling of const (that this patch neither introduces nor fixes). In
particular, the following are allowed:

var x = 1;
const x = 2;

const y = 1;
const y = 2;

There are some more elaborate ones than this, but I will file them all as a
separate bug and include a fix. I simply wanted to mention it here because it
is more apparent after looking at the code in this patch.

More information about the webkit-reviews mailing list