[webkit-reviews] review requested: [Bug 14383] [S60] Problem with CPluginSkin::PluginScriptableObject : [Attachment 15482] 3.1m Patch for scriptability check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 23:08:58 PDT 2007

maheshK <mahesh.kulkarni at nokia.com> has asked Sachin Padma
<Sachin.Padma at nokia.com> for review:
Bug 14383: [S60] Problem with CPluginSkin::PluginScriptableObject

Attachment 15482: 3.1m Patch for scriptability check

------- Additional Comments from maheshK <mahesh.kulkarni at nokia.com>
According to Sriram/AnttiH/Yael comments, checking for scriptability of plugins
is specific to plugin UID which is compared with the one in browser/webui

1) Added KPluginScriptabilityAllowed in KCRUidBrowser and KCRUidWebUi
2) KPluginScriptabilityAllowed can have more than one plugin's UID's
3) Added Api PluginInfo->Uid() to get plugin UID
4) Added Api PluginWin->GetPluginUid() to access plugin UID in pluginSkin
5) Added Api pluginSkin->IsPluginScriptableL checks if
KPluginScriptabilityAllowed present in the repository. 

Note: I have not attached xls files. Because I am not sure should we add or how
to add xls files here. And even BrowserUiInternalCRKeys.h file which is not
part of OssWebEngine.

More information about the webkit-reviews mailing list