[webkit-reviews] review denied: [Bug 14516] crash loading multipart/x-mixed-replace data on windows safari : [Attachment 15379] null check m_resourceData

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 16:29:20 PDT 2007


Maciej Stachowiak <mjs at apple.com> has denied idealisms at gmail.com's request for
review:
Bug 14516: crash loading multipart/x-mixed-replace data on windows safari
http://bugs.webkit.org/show_bug.cgi?id=14516

Attachment 15379: null check m_resourceData
http://bugs.webkit.org/attachment.cgi?id=15379&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Good fix. Please add an http layout test (the tests in LayoutTests/http run on
a local server, so you can generate multipart/x-mided-replace output). Also,
please add an explanation of the bug being fixed to the ChangeLog entry.

r- for now, please resubmit with these things fixed.



More information about the webkit-reviews mailing list