[webkit-reviews] review denied: [Bug 13038] ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame : [Attachment 15314] another patch :)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 03:36:29 PDT 2007


Maciej Stachowiak <mjs at apple.com> has denied Maxime BRITTO
<mbritto at pleyo.com>'s request for review:
Bug 13038: ASSERTION FAILED: item->target().isEmpty() ||
m_mainFrame->tree()->find(item->target()) == m_mainFrame
http://bugs.webkit.org/show_bug.cgi?id=13038

Attachment 15314: another patch :)
http://bugs.webkit.org/attachment.cgi?id=15314&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
If the test has to be done manually, then instead of LayoutTests it should go
in WebCore/manual-tests.

Otherwise patch looks fine. I will mark this r- but if you can get a committer
to fix this while landing that's cool.



More information about the webkit-reviews mailing list