[webkit-reviews] review denied: [Bug 14437] CRASH: RTÉ video crashes Safari : [Attachment 15371] Tweaked initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 12:28:31 PDT 2007

Darin Adler <darin at apple.com> has denied Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 14437: CRASH: RTÉ video crashes Safari

Attachment 15371: Tweaked initial patch

------- Additional Comments from Darin Adler <darin at apple.com>
I just talked this over with Anders. It's clear that in cases where the JSValue
is an object, we can't return the object, because we can't run its toString
method in the right context -- the context is gone because the frame is

But in the simple cases where the JSValue is not an object, it seems there's no
reason we can't return the value. So I suggest we make a version of toString
that works on non-object JSValue, and use that if m_frame is nil. That way the
common cases of plain old strings and such will work fine.

That seems slightly better than always returning nil. review- until we at least
consider that option.

More information about the webkit-reviews mailing list