[webkit-reviews] review requested: [Bug 14437] CRASH: RTÉ video crashes Safari : [Attachment 15346] alternate fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 2 03:13:18 PDT 2007

Maxime BRITTO <mbritto at pleyo.com> has asked  for review:
Bug 14437: CRASH: RTÉ video crashes Safari

Attachment 15346: alternate fix

------- Additional Comments from Maxime BRITTO <mbritto at pleyo.com>
We talk about this with Mitz (which prefers the "RefPtr" fix) and Andersca
(which prefer the "return nil" fix) on friday on IRC and Andersca convinced us
that returning nil what the best way to fix this.

Still, I tried	the RefPtr way and it doesn't work because we get a nil script
proxy (KJSProxy) and it crashes when trying to interpret.

I've found a third way to fix this if you really want to return something in
all cases : protecting the ExecState instead of the frame.This way it works and
no test case is affected.

More information about the webkit-reviews mailing list