[webkit-reviews] review denied: [Bug 10517] REGRESSION (r12065-r12082): Navigation graphic wraps to the next line on duart.com : [Attachment 12848] Patch to implement quirk

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Jan 31 22:23:34 PST 2007


Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 10517: REGRESSION (r12065-r12082): Navigation graphic wraps to the next
line on duart.com
http://bugs.webkit.org/show_bug.cgi?id=10517

Attachment 12848: Patch to implement quirk
http://bugs.webkit.org/attachment.cgi?id=12848&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You can use style->htmlHacks() to ask if you're in quirks mode in a more
compact way.

The sibling checks are flawed, since content can be nested.  That's why there's
an iterator that was drilling into and out of nested inline flows like spans
and such to find all the text/image leaves.  I'm not sure why the sibling
checks are necessary.

I also don't understand the table cell width check, since that should be
factored into min/max width later on.

Maybe we can look at this in person tomorrow to see what the failures were with
a less specific version of the quirk.



More information about the webkit-reviews mailing list