[webkit-reviews] review requested: [Bug 6484] font-weight does not properly support graded weights : [Attachment 12829] nickshanks' work-in-progress patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Jan 31 10:56:36 PST 2007


Nicholas Shanks <contact at nickshanks.com> has asked  for review:
Bug 6484: font-weight does not properly support graded weights
http://bugs.webkit.org/show_bug.cgi?id=6484

Attachment 12829: nickshanks' work-in-progress patch
http://bugs.webkit.org/attachment.cgi?id=12829&action=edit

------- Additional Comments from Nicholas Shanks <contact at nickshanks.com>
This is my working diff, submitted for comment. It does not attempt to fix
CSSComputedStyleDeclaration.cpp nor WebHTMLView.mm correctly yet (which were
already marked FIXME). Please ignore these issues for the time being.

As noted in my previous comment, it uses a fourteen-point graded weight system
on Mac to allow ease of comparison to NSFontManager values.
cssstyleselector.cpp contains the conversion values. Qt keeps the existing
system, and other platforms get a 9-point one based on CSS.

The CSS_PROP_FONT_WEIGHT and _STRETCH switch statements are so ordered for
speed reasons in common case usage. Use of cDemiBoldWeight as a value for
minimum weight considered '"bold" is a temporary hack.

Also includes changes submitted as bug #12481 and bug #12482 because it would
be hassle to remove them from my tree.

I have not ran existing regression tests yet, as I expect quite a few will
require new expected results. New tests and a changelog are forthcoming. Please
don't r- the patch until several people have had a chance to see it and
comment.



More information about the webkit-reviews mailing list