[webkit-reviews] review denied: [Bug 12488] Paint server in objectBoundingBox mode not ignored if path has an empty bounding box : [Attachment 12812] Patch v1

[bugzilla-request-daemon at macosforge.org]

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 12488: Paint server in objectBoundingBox mode not ignored if path has an
empty bounding box
http://bugs.webkit.org/show_bug.cgi?id=12488

Attachment 12812: Patch v1
http://bugs.webkit.org/attachment.cgi?id=12812&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I think this is OK.  I'm not a huge fan of tying buildEffectiveAttributes()
dependencies into the server resolution.  I think it fit better inside a
setup() call.

Also, I dont' think this is right:

+    if (!strokePaintServer) {
+	 // default value (black)
+	 strokePaintServer = sharedSolidPaintServer();
+	
static_cast<SVGPaintServerSolid*>(strokePaintServer)->setColor(Color::black);
+    }

that should just be special cased into 
+	     if (strokePaintServer->boundingBoxMode() &&
item->relativeBBox(false).isEmpty())
+		 strokePaintServer = 0;
instead.

Otherwise I think the patch is OK.

You should definitely have a reference to the spec about the empty bounding
box.

Oh, and I don't think you need to special case this for fill servers.  I don't
see how you could ever end up drawing a fill when there is no bounding box.