[webkit-reviews] review requested: [Bug 12488] Paint server in objectBoundingBox mode not ignored if path has an empty bounding box : [Attachment 12812] Patch v1

[bugzilla-request-daemon at macosforge.org]

Rémi Zara <remi_zara at mac.com> has asked  for review:
Bug 12488: Paint server in objectBoundingBox mode not ignored if path has an
empty bounding box
http://bugs.webkit.org/show_bug.cgi?id=12488

Attachment 12812: Patch v1
http://bugs.webkit.org/attachment.cgi?id=12812&action=edit

------- Additional Comments from Rémi Zara <remi_zara at mac.com>
This patch fixes the W3C test, and add a new one that test pattern, and
gradient/pattern attribute inheritance. I've not looked at filters, clips and
masks.

I'm not quite sure why in my new test the last pattern is blank and not green.

The patch use a black solid color when the objectBoundingBox mode is "on" and
the path has an empty boundingbox. The spec says that the effect should be
ignored. Does this mean the stroke or fill should be inherited ?

I also find the "building" of paint server not ideal. It seems to be redone
every time the paint server is used. Why isn't there a "computed attributes" on
the Element, which would be calculated on demand (or when a referenced element
is changed) ?