[webkit-reviews] review granted: [Bug 12050] REGRESSION: Assertion failure in -[WebBaseNetscapePluginView willCallPlugInFunction] (plugin) : [Attachment 12796] Proposed fix

[bugzilla-request-daemon at macosforge.org]

Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 12050: REGRESSION: Assertion failure in -[WebBaseNetscapePluginView
willCallPlugInFunction] (plugin)
http://bugs.webkit.org/show_bug.cgi?id=12050

Attachment 12796: Proposed fix
http://bugs.webkit.org/attachment.cgi?id=12796&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
No, I guess this is no different from display:none, so this fix is probably
right.

I'm more confident in it now that I see the original page was trying to access
.outerHTML, not the plug-in.

I do still wonder if there are sites out there that break when you load them
into background tabs, because doing so makes their plug-ins unscriptable, but I
guess we can cross that bridge if we ever come to it.