[webkit-reviews] review requested: [Bug 12050] REGRESSION: Assertion failure in -[WebBaseNetscapePluginView willCallPlugInFunction] (plugin) : [Attachment 12796] Proposed fix

[bugzilla-request-daemon at macosforge.org]

Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 12050: REGRESSION: Assertion failure in -[WebBaseNetscapePluginView
willCallPlugInFunction] (plugin)
http://bugs.webkit.org/show_bug.cgi?id=12050

Attachment 12796: Proposed fix
http://bugs.webkit.org/attachment.cgi?id=12796&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Guys, I'm not sure this is the right fix. I think the real bug here is that the
plug-in is in the page, and JavaScript holds a reference to it, but it hasn't
started yet. Why wasn't -start called?

Here's the bug that I think this doesn't fix: obj.SetVariable("x", 1). That's a
valid call to the Flash plug-in, but it would throw an exception because WebKit
would think the plug-in hadn't loaded, right?

Or is this fix specific to the case of an <object> element that has no data
attribute, so there is plug-in to load?

I'm setting the review flag back to "?" so this doesn't show up in the commit
queue for now. Feel free to set it back to "+" if I'm off my rocker.