[webkit-reviews] review requested: [Bug 12452] XPath id() function is not supported : [Attachment 12801] proposed fix

[bugzilla-request-daemon at macosforge.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 12452: XPath id() function is not supported
http://bugs.webkit.org/show_bug.cgi?id=12452

Attachment 12801: proposed fix
http://bugs.webkit.org/attachment.cgi?id=12801&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> I'm irritated to see yet-another isWhitespace function.

  There was a single identical one I could find, in SVGParserUtilities.h. I
believe parts of this file should be abstracted out, because they have nothing
to do with SVG.

> String is extremely inefficient to append to; it reallocates each time.

  I allowed myself this sloppiness, because I couldn't see how this would
noticeably slow down XPath -but OK.