[webkit-reviews] review granted: [Bug 12452] XPath id() function is not supported : [Attachment 12799] implement id()

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12452: XPath id() function is not supported
http://bugs.webkit.org/show_bug.cgi?id=12452

Attachment 12799: implement id()
http://bugs.webkit.org/attachment.cgi?id=12799&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

I'm irritated to see yet-another isWhitespace function. I'd like to see us
figure out which flavors of this we need and share central copies with
easy-to-understand names.

String is extremely inefficient to append to; it reallocates each time. So a
loop that appends the string value and then a space is O(n^2) the size of the
string. The way to avoid this is to use a Vector<UChar> instead, and convert to
a String at the end with String::adopt.