[webkit-reviews] review requested: [Bug 12452] XPath id() function is not supported : [Attachment 12799] implement id()

[bugzilla-request-daemon at macosforge.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 12452: XPath id() function is not supported
http://bugs.webkit.org/show_bug.cgi?id=12452

Attachment 12799: implement id()
http://bugs.webkit.org/attachment.cgi?id=12799&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I have certain doubts about XPathResult ordering. The existing code expects
that it is each function's duty to preserve ordering, but that would be fairly
inefficient when the client doesn't need ordered results. Maybe it would be
better to re-order results in XPathResult::convertTo().

Similar issues arise for ANY_UNORDERED_NODE_TYPE, FIRST_ORDERED_NODE_TYPE and
iterator types - building a full snapshot just to provide one of these is
inefficient.