[webkit-reviews] review requested: [Bug 6000] <use> does not handle recursion safely : [Attachment 12788] Final patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Jan 30 04:34:06 PST 2007


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 6000: <use> does not handle recursion safely
http://bugs.webkit.org/show_bug.cgi?id=6000

Attachment 12788: Final patch
http://bugs.webkit.org/attachment.cgi?id=12788&action=edit

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Finally it does not leak anymore! The problematic area was SVGElementInstance,
it always ref()'ed the correspondingUseElement so these never got deleted, once
expandUseElementsInShadowTree() was executed. No new regressions - <use> feels
much more stable today (ie. carto.net/window.svg works _perfectly_ now - no
bugs!), no new leaks. All fine :-)



More information about the webkit-reviews mailing list